check clean status of all dependencies before dev test, #310

js/common/getDependencies.js

@@ -16,7 +16,7 @@ const winston = require( 'winston' );
  * @param {string} repo - The repository name
  * @returns {Promise} - Resolves to the dependencies.json content
  */
-module.exports = function( repo ) {
+module.exports = function getDependencies( repo ) {
   winston.info( `getting dependencies.json for ${repo}` );
 
   return loadJSON( `../${repo}/dependencies.json` );

js/common/getDependencyRepos.js

@@ -0,0 +1,24 @@
+// Copyright 2017-2023, University of Colorado Boulder
+
+/**
+ * The repos (keys) from dependencies.json of a repository
+ *
+ * @author Jonathan Olson <jonathan.olson@colorado.edu>
+ * @author Michael Kauzmann (PhET Interactive Simulations)
+ */
+
+const loadJSON = require( './loadJSON' );
+const winston = require( 'winston' );
+
+/**
+ * @public
+ *
+ * @param {string} repo - The repository name
+ * @returns {Promise} - Resolves to the list of repos in the dependencies.json of the provided repo
+ */
+module.exports = async function getDependencyRepos( repo ) {
+  winston.info( `getting dependencies.json for ${repo}` );
+
+  const json = await loadJSON( `../${repo}/dependencies.json` );
+  return Object.keys( json ).filter( key => key !== 'comment' );
+};

js/grunt/dev.js

@@ -17,6 +17,7 @@ const getBranch = require( '../common/getBranch' );
 const getRemoteBranchSHAs = require( '../common/getRemoteBranchSHAs' );
 const getRepoVersion = require( '../common/getRepoVersion' );
 const gitIsClean = require( '../common/gitIsClean' );
+const getDependencyRepos = require( '../common/getDependencyRepos' );
 const gitPush = require( '../common/gitPush' );
 const gitRevParse = require( '../common/gitRevParse' );
 const lintAllRunnable = require( '../common/lintAllRunnable' );
@@ -68,9 +69,13 @@ module.exports = async function( repo, brands, noninteractive, branch, message )
     }
   }
 
-  const isClean = await gitIsClean( repo );
-  if ( !isClean ) {
-    throw new Error( `Unclean status in ${repo}, cannot deploy` );
+  const dependencies = await getDependencyRepos( repo );
+  for ( let i = 0; i < dependencies.length; i++ ) {
+    const dependency = dependencies[ i ];
+    const isClean = await gitIsClean( dependency );
+    if ( !isClean ) {
+      throw new Error( `Unclean status in ${dependency}, cannot deploy` );
+    }
   }
 
   const currentSHA = await gitRevParse( repo, 'HEAD' );