-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup standard ECS GH workflows #9
Changes from all commits
455040c
5885163
db0146c
70923f8
53faf2a
cc6db60
d5f5c66
d810c1e
b36a0a5
7b717ec
d6142d1
6db134b
c60d466
86b6c01
0584731
dc65a7e
3c8f1bc
191812f
e65b028
1a545c4
5dfe672
51b5126
aed0f7a
1d2adaa
38cfd8a
ffa2329
3acf10c
98d55e7
8c7e186
9b10cd6
bb75759
9a79bbc
e9e408a
f97735c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[run] | ||
source = | ||
btms_ui | ||
btms-ui | ||
[report] | ||
omit = | ||
#versioning | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,23 @@ | ||
[flake8] | ||
exclude = .git,__pycache__,build,dist,versioneer.py,btms_ui/_version.py,docs/source/conf.py | ||
exclude = .git,__pycache__,build,dist,btms_ui/_version.py | ||
max-line-length = 88 | ||
select = C,E,F,W,B,B950 | ||
extend-ignore = E203, E501 | ||
extend-ignore = E203, E501, E226, W503, W504 | ||
|
||
# Explanation section: | ||
# B950 | ||
# This takes into account max-line-length but only triggers when the value | ||
# has been exceeded by more than 10% (96 characters). | ||
# E203: Whitespace before ':' | ||
# This is recommended by black in relation to slice formatting. | ||
# E501: Line too long (82 > 79 characters) | ||
# Our line length limit is 88 (above 79 defined in E501). Ignore it. | ||
# E226: Missing whitespace around arithmetic operator | ||
# This is a stylistic choice which you'll find everywhere in pcdsdevices, for | ||
# example. Formulas can be easier to read when operators and operands | ||
# have no whitespace between them. | ||
# | ||
# W503: Line break occurred before a binary operator | ||
# W504: Line break occurred after a binary operator | ||
# flake8 wants us to choose one of the above two. Our choice | ||
# is to make no decision. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
node: $Format:%H$ | ||
node-date: $Format:%cI$ | ||
describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$ | ||
ref-names: $Format:%D$ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
btms_ui/_version.py export-subst | ||
.git_archival.txt export-subst |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
name: PCDS Standard Testing | ||
|
||
on: | ||
push: | ||
pull_request: | ||
release: | ||
types: | ||
- published | ||
|
||
jobs: | ||
standard: | ||
uses: pcdshub/pcds-ci-helpers/.github/workflows/python-standard.yml@master | ||
with: | ||
# The workflow needs to know the package name. This can be determined | ||
# automatically if the repository name is the same as the import name. | ||
package-name: "btms_ui" | ||
# Extras that will be installed for both conda/pip: | ||
testing-extras: "" | ||
# Extras to be installed only for conda-based testing: | ||
conda-testing-extras: "" | ||
# Extras to be installed only for pip-based testing: | ||
pip-testing-extras: "" | ||
# Set if using setuptools-scm for the conda-build workflow | ||
use-setuptools-scm: true |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
from . import _version | ||
__version__ = _version.get_versions()['version'] | ||
from ._version import __version__ # noqa: F401 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might be missing when running interactively since it's generated by setuptools_scm later. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can't say I fully understand here, but it's working interactively on my clone. Once this is merged I can set up a clean clone and test that it still works interactively, and if not set up a new issue/PR to resolve that. |
||
|
||
__all__ = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your experience here is why I dislike using dashes at all in package names