Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #432: cloud path is not working in Windows due to absolute file path protocol #449

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rjcodedev
Copy link

@rjcodedev rjcodedev commented Jan 10, 2024

issue fix #432 for windows and it also work for linux , macos too

Copy link

parse-github-assistant bot commented Jan 10, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@rjcodedev rjcodedev changed the title fix #432: cloud path is not working in Windows due absolute paths protocol fix #432: cloud path is not working in Windows due to absolute file path protocol Jan 10, 2024
@rjcodedev
Copy link
Author

Closes: #432

Comment on lines +13 to +15
cloud: function () {
import('./cloud/main.js');
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would ignore the env var; could you refactor? I think the path can be set in an OS agnostic way, using the url lib, instead of __dirname and for example url.fileURLToPath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants