Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2409] Backport #5563 #5820

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[stable2409] Backport #5563 #5820

merged 1 commit into from
Sep 24, 2024
+61 −23

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link

Backport #5563 into stable2409 from acatangiu.

See the documentation on how to use this bot.

@acatangiu @github-actions
snowbridge: improve destination fee handling to avoid trapping fees d…
b655e43 
…ust (#5563)

On messages Ethereum -> Polkadot Asset Hub: whether they are a token
transfer or a `Transact` for registering new token, make sure to handle
unspent fees, rather than trapping them.

This PR deposits them to Snowbridge's sovereign account on Asset Hub.

---------

Co-authored-by: command-bot <>
(cherry picked from commit 62534e5)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Sep 24, 2024
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 24, 2024
@paritytech-review-bot paritytech-review-bot bot requested a review from a team September 24, 2024 12:47
@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@acatangiu acatangiu merged commit 4ff4066 into stable2409 Sep 24, 2024
178 of 187 checks passed
@acatangiu acatangiu deleted the backport-5563-to-stable2409 branch September 24, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

Assignees

@acatangiu acatangiu

Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@acatangiu