Implement try_append for StorageNMap #5745
Merged
+104
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
kianenigma
reviewed
Sep 21, 2024
| assert_ok!(FooQuadMap::try_append((2, 1, 1, 1), 5)); | ||
| assert_eq!( | ||
| FooQuadMap::get((2, 1, 1, 1)).unwrap(), | ||
| BoundedVec::<u32, ConstU32<7>>::try_from(vec![4, 5]).unwrap(), |
There was a problem hiding this comment.
There was a problem hiding this comment.
code above uses the same syntax, so i think this is fine
kianenigma
approved these changes
Sep 21, 2024
shawntabrizi
approved these changes
Sep 23, 2024
|
/tip medium @CJ13th follow the instructions below to receive a tip |
|
@CJ13th Contributor did not properly post their account address. Make sure the pull request description (or user bio) has: "{network} address: {address}". |
shawntabrizi
added
the
T1-FRAME
shawntabrizi
approved these changes
Sep 23, 2024
Merged
via the queue into
paritytech:master
with commit Sep 23, 2024
e0766bb
207 of 209 checks passed
|
Thanks all for reviewing and merging. @shawntabrizi I have updated the pull request description and my bio to include my DOT address. |
|
/tip medium |
|
The referendum has appeared on Polkassembly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5722
Added an implementation of the
try_appendfunctionality which is present on the other storage map types but currently missing from StorageNMap.polkadot address: 12VNFoH4iy4227mpTPvUbUbAnYv7of6LhWcD6EUik3VfFHbD