-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4 / 5] Make approval-voting runnable on a worker thread #4846
Conversation
381e0b9
to
88e15da
Compare
31767a9
to
7add070
Compare
7add070
to
78708d7
Compare
88e15da
to
7c968e1
Compare
7add070
to
3a0ba90
Compare
7c968e1
to
5fe747c
Compare
3a0ba90
to
78bb23d
Compare
5fe747c
to
e4f883e
Compare
25f1f0a
to
d13e1c8
Compare
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
e4f883e
to
14727c5
Compare
d13e1c8
to
1942139
Compare
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…l-1-5' into alexaggh/approval-voting-parallel-3-5
- rename check_and_import in import. - refactor un-needed variable. Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…l-3-5' into alexaggh/approval-voting-parallel-2-5
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…oting-parallel-3-5
…l-3-5' into alexaggh/approval-voting-parallel-2-5
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…l-3-5' into alexaggh/approval-voting-parallel-2-5
…oting-parallel-3-5
…l-3-5' into alexaggh/approval-voting-parallel-2-5
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…oting-parallel-3-5
…proval-voting-parallel-2-5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
…oting-parallel-3-5
…ting Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…proval-voting-parallel-2-5
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job!
…oting-parallel-2-5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
This is part of the work to further optimize the approval subsystems, if you want to understand the full context start with reading #4849 (comment),
Description
This PR contain changes to make possible the run of single approval-voting instance on a worker thread, so that it can be instantiated by the approval-voting-parallel subsystem.
This does not contain any functional changes it just decouples the subsystem from the subsystem Context and introduces more specific trait dependencies for each function instead of all of them requiring a context.
This change can be merged independent of the followup PRs.