Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Refactor docker image build #3045

Merged
merged 46 commits into from
Aug 24, 2023
Merged

Refactor docker image build #3045

merged 46 commits into from
Aug 24, 2023

Conversation

EgorPopelyaev
Copy link
Contributor

@EgorPopelyaev EgorPopelyaev commented Aug 22, 2023 •
edited
Loading

This PR refactors github actions which build the docker image for the polkadot-parachainbinary. It touches both flows automated and manual.
From now on it is going to be only one workflow which triggers automatically, when a new release is published or can be triggered manually on demand to publish an RC or Release image

@EgorPopelyaev
add lib.sh file from polkadot to reuse existing functionality
57c50f0
@EgorPopelyaev
use personal repo for test
2fbb931
@EgorPopelyaev
add debug line for visibility
810ac0c
@EgorPopelyaev
add more debug
c88662b
@EgorPopelyaev
make lib.sh executable
c6e3536
@EgorPopelyaev
more debugging
7701c93
@EgorPopelyaev
add permissons to read conents
7f4a66a
@EgorPopelyaev
test write permissions for the contents
137bc3a
@EgorPopelyaev
try download wothout token
5690b8f
@EgorPopelyaev
cleanup
360f8ef
@EgorPopelyaev
add lib.sh from polkadot to the manual step
e8cbd2d
@EgorPopelyaev
add new manual docker image build + renaming of the release image build
2e8ac20
@EgorPopelyaev
replace existing manual docker image publishing to test
0cbeb2c
@EgorPopelyaev
add checkout of lib.sh from polkadot
d1d7ed0
@EgorPopelyaev
copy lib.sh from temp to the artifacts folder
3bd0d07
@EgorPopelyaev
change path to the artifacts folder and cleanup
34678bd
@EgorPopelyaev
rename to test
854be18
@EgorPopelyaev
make binary executable
3235ef7
@EgorPopelyaev
fix path to binary in the for loop
e969bf1
@EgorPopelyaev
add debug
3cf31da
@EgorPopelyaev
make bin executable right after fetching it
21e833a
@EgorPopelyaev
change is_final field to a string value
22fc64d
@EgorPopelyaev
Add semver version extraction for a tag
3bf3845
@EgorPopelyaev
add tags to the image
adc16c9
@EgorPopelyaev
tag iamge after it was built
0bfd7a1
@EgorPopelyaev
refactor tagging
41f00e4
@EgorPopelyaev
fix docker owner issue in build step
17bdab4
@EgorPopelyaev
push right after tagging in loop
8d4ecc2
@EgorPopelyaev
rename of the file
f7d1338
@EgorPopelyaev
cleanup
49d3376
@EgorPopelyaev EgorPopelyaev added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 22, 2023
@EgorPopelyaev EgorPopelyaev requested review from a team as code owners August 22, 2023 13:42
chevdor
chevdor suggested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes but that loooks good already.
I would be nice to keep only ONE single workflow, that can handle workflow_dispatch if the needs occurs. That would also be easier to maintain that 2 worfklows we need to keep in sync.

.github/workflows/release-50_publish-docker-manual.yml Outdated Show resolved Hide resolved
.github/workflows/release-50_publish-docker-manual.yml Outdated Show resolved Hide resolved
chevdor
chevdor approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside the indentation remark

.github/workflows/release-50_publish-docker.yml Outdated Show resolved Hide resolved
@EgorPopelyaev
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit d0006ba into paritytech:master Aug 24, 2023
41 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chevdor chevdor chevdor approved these changes

@alvicsam alvicsam alvicsam approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EgorPopelyaev @chevdor @alvicsam