Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type checking #76

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add type checking #76

wants to merge 1 commit into from

Conversation

irahopkinson
Copy link
Contributor

@irahopkinson irahopkinson commented Aug 29, 2024

  • use noImplicitReturns instead of consistent-return

Note this is draft because I had to comment out 3 lines in tsconfig.json in order to get the type checking passing. We don't strictly need to have it passing here since we don't check it on commit however having it failing might not be great either and the commented lines are either removed or modified in core anyway.


This change is Reviewable

- use `noImplicitReturns` instead of `consistent-return`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant