Implicitly include self in dependents of a koji_build job #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is possible to omit declaring self as a dependency
in `bodhi_update` job, it is still necessary to explicitly declare
self as a dependent for the `bodhi_update` job to be triggered:
```
downstream_package_name: foo
jobs:
- job: koji_build
trigger: commit
sidetag_group: test
dependents:
- foo
- job: bodhi_update
trigger: koji_build
sidetag_group: test
# dependencies:
# - foo
```
Fix that.
Signed-off-by: Nikola Forró <nforro@redhat.com>
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 10s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 09s |
softwarefactory-project-zuul
bot
merged commit 6f08bb5
into
packit:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is possible to omit declaring self as a dependency in
bodhi_updatejob, it is still necessary to explicitly declare self as a dependent for thebodhi_updatejob to be triggered:Fix that.