Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes spacing of icons and adds info for element details #31

Merged
merged 10 commits into from
Oct 23, 2023

Conversation

paceaux
Copy link
Owner

@paceaux paceaux commented Oct 11, 2023

Adds a new dependency for making fancy boxes
Adds actual icons in the cli instead of whatever that was before.
Makes the final result a tad more colorful

@paceaux
Copy link
Owner Author

paceaux commented Oct 11, 2023

logger was updated, but doesn't have enough jsdoced stuff. come on man.

@paceaux
Copy link
Owner Author

paceaux commented Oct 17, 2023

Yeah most of the tests are failing. All of the tests that rely on anything where logger is injected will have a problem.

@paceaux
Copy link
Owner Author

paceaux commented Oct 18, 2023

Most of the tests are passing again. They were failing because of the import '#whatever' syntax that was in chalk. This was a known issue in Jest By updating Jest, most unit tests pass.

Only test suite failing to run is selector-finder.puppeteer.test.js:

 The error below may be caused by using the wrong test environment, see https://jestjs.io/docs/configuration#testenvironment-string.
    Consider using the "jsdom" test environment.
    
    ReferenceError: navigator is not defined

      at node_modules/boxen/node_modules/chalk/source/vendor/supports-color/browser.js:4:2
      at node_modules/boxen/node_modules/chalk/source/vendor/supports-color/browser.js:16:3

Frank M. Taylor added 3 commits October 20, 2023 09:27
This could help get past some issues with jest using the environment-version of some libs
@paceaux paceaux merged commit 676f530 into develop Oct 23, 2023
1 check passed
@paceaux
Copy link
Owner Author

paceaux commented Oct 23, 2023

Finally got all tests passing with correctly importing the proper environment and then doing proper setup.

Let's merge it!

@paceaux paceaux deleted the paceaux/issue15-improve-logging-cli-experience branch August 21, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant