Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRUD Personas #7

Closed
wants to merge 2 commits into from
Closed

CRUD Personas #7

wants to merge 2 commits into from

Conversation

rquesada
Copy link
Contributor

Summary

This PR modifies the object Persona and PersonaCreate, changing the fields voiceId to Voice object and faceId to Face object

Changes

  • Added Voice schema
  • Added Face schema
  • Modified Persona
  • Modified PersonaCreate

Related Issues

N/A

Type of Change

This change solved the comments posted on the review of the previous PR created by @rquesada [https://github.com//pull/4]

Checklist

  • I have read the CONTRIBUTING documentation.
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the documentation (if applicable).

Screenshots (if applicable)

image
image
image

Additional Context

Tested locally using Swagger.
Based on the premise that we are not expecting that faces and voices to be modified frequently, so the approach we considered here was to create an "assets" folder (in the front-end) to store the images, videos and audios. Then it was only going to be necessary to store the id of voice and face to help us associate the asset with the voice and face.

For example:
Given the object Persona:

      {
        "name": "Mari",
        "description": "Mari A",
        "voiceId": "x4te5a69-40d6-4246-8d53-f4c777be8080",
        "faceId": "7ffe5a69-40d6-4246-8d54-f4c777be6989",
        "id": "91a7542f-da52-46ab-85b9-08f871722e93"
      }

The frontend will be able to load the files:
:/assests/audio/x4te5a69-40d6-4246-8d53-f4c777be8080.mp3
:/assests/face/7ffe5a69-40d6-4246-8d54-f4c777be6989.jpg
:/assests/video/7ffe5a69-40d6-4246-8d54-f4c777be6989.mp4

@rquesada rquesada requested a review from quaid as a code owner July 26, 2024 18:22
@quaid quaid mentioned this pull request Jul 30, 2024
7 tasks
@samj
Copy link
Contributor

samj commented Aug 6, 2024

You've got a merge done through the GitHub UI/API (e4b4044) and it looks like you've replaced OpenAI's openapi.yaml with ours.

@rquesada
Copy link
Contributor Author

rquesada commented Aug 7, 2024

A new PR was created to fix the comments @samj

@rquesada rquesada closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants