Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRUD Personas with fixes #24

Closed
wants to merge 5 commits into from
Closed

CRUD Personas with fixes #24

wants to merge 5 commits into from

Conversation

rquesada
Copy link
Contributor

@rquesada rquesada commented Aug 7, 2024

Summary

This PR modifies the object Persona and PersonaCreate, changing the fields voiceId to Voice object and faceId to Face object

Changes

  • Modified Persona
  • Modified PersonaCreate

Related Issues

N/A

Type of Change

This change solved the comments posted on the review of the previous PR created by @rquesada [https://github.com//pull/4]

Checklist

  • I have read the CONTRIBUTING documentation.
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the documentation (if applicable).

Screenshots (if applicable)

image
Screenshot 2024-08-07 at 1 32 40 PM
image

Additional Context

Tested locally using Swagger.
Based on the premise that we are not expecting that faces and voices to be modified frequently, so the approach we considered here was to create an "assets" folder (in the front-end) to store the images, videos and audios. Then it was only going to be necessary to store the id of voice and face to help us associate the asset with the voice and face.

For example:
Given the object Persona:

      {
        "name": "Mari",
        "description": "Mari A",
        "voice_id": "x4te5a69-40d6-4246-8d53-f4c777be8080",
        "face_id": "7ffe5a69-40d6-4246-8d54-f4c777be6989",
        "id": "91a7542f-da52-46ab-85b9-08f871722e93"
      }

The frontend will be able to load the files:
:/assests/audio/x4te5a69-40d6-4246-8d53-f4c777be8080.mp3
:/assests/face/7ffe5a69-40d6-4246-8d54-f4c777be6989.jpg
:/assests/video/7ffe5a69-40d6-4246-8d54-f4c777be6989.mp4

@rquesada rquesada added the enhancement New feature or request label Aug 7, 2024
@rquesada rquesada self-assigned this Aug 7, 2024
@samj samj changed the base branch from main to develop August 9, 2024 21:16
@samj
Copy link
Contributor

samj commented Aug 9, 2024

Rebased the PR commits onto develop, fast-forwarded develop to include them, and fixed a warning in 67edb65.

@rquesada
Copy link
Contributor Author

It is already merged in other commit

@rquesada rquesada closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants