[mpd] outputs: drop invalid outputsvolume key #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This key confuses some clients, and it isn't emitted by MPD, nor documented to exist: https://github.com/MusicPlayerDaemon/MPD/blob/9ff8e02e543ede2b1964e5ea3f26f00bf2ff90ec/src/output/Print.cxx It was added in bdb2c74, but without explanation why it was added to outputs command. Signed-off-by: Fabian Groffen <grobian@gentoo.org>
|
The original MPD upstream mail convo that's being referred to no longer exists, as it stands it is an owntone addition/deviation from the standard. I don't mind that so much, but in the past you expressed a desire to match the reference server as closely as possible. |
|
Yes, the link was just fyi (and for future reference). I do agree that it should be removed. Back when it was added there wasn't any json api, so mpd was the "easy" cli/script interface to owntone/forked-daapd, but now it's better to use the api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This key confuses some clients, and it isn't emitted by MPD, nor documented to exist:
https://github.com/MusicPlayerDaemon/MPD/blob/9ff8e02e543ede2b1964e5ea3f26f00bf2ff90ec/src/output/Print.cxx
It was added in bdb2c74, but without explanation why it was added to outputs command.