SW-5167: follow ups from SW-5167-fix-black-columns-when-recording-under-ros-foxy #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cloud_frame through launch xml files + Remove unused/duplicate param definitions + Update descriptions
Samahu
requested review from
bexcite,
twslankard,
celentes,
kairenw and
chrisbayruns
bexcite
approved these changes
Jul 12, 2023
kairenw
approved these changes
Jul 13, 2023
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
Summary of Changes
point_cloud_framewith an empty stringValidation
Launch a live sensor using the xml launch file format setting only the value of the sensor_hostname
ros2 launch ouster_ros sensor.launch.xml
sensor_hostname:=
Once the sensor connects verify that all topics are using a BEST_EFFORT policy using:
ros2 topic echo -v "topic_name"
Launch record.launch.xml as follows:
ros2 launch ouster_ros record.launch.xml
sensor_hostname:=
bag_file:=
Once the sensor connects verify that all topics are using a RELIABLE policy using:
ros2 topic echo -v "topic_name"