Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Typescript for frontend #13

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Anjali0407-git
Copy link
Collaborator

Fixes #12

  • Migrated to Typescirpt

  • This change is needed to make the frontend Statically typed and error-free

  • Added tsconfig file at the root and updated compiler options in it. Updated DonorForm into .tsx with appropriate syntactical changes. DonorForm

…pescript dependencies; updated donor form into typescript
Copy link
Collaborator

@kungfuchicken kungfuchicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;

i noticed you flipped some single-tick quotes to double. do you have that linting captured in your pipeline and local dev setups? it would suck to have to deal with those flipping bakc-and-forth if different devs are handling them differently.

@Anjali0407-git Anjali0407-git merged commit 0f7b256 into main Sep 13, 2024
1 check passed
@Anjali0407-git
Copy link
Collaborator Author

lgtm;

i noticed you flipped some single-tick quotes to double. do you have that linting captured in your pipeline and local dev setups? it would suck to have to deal with those flipping bakc-and-forth if different devs are handling them differently.

Yes you are right. That formatting is because of the prettify extension that I use in my local vscode. I will add a config file to ensure same linting and formatting rules applies to everyone. I am merging this and creating a new issue for this.

@Anjali0407-git Anjali0407-git deleted the 12-migrate-to-typescript-in-frontend branch September 13, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Typescript in frontend
2 participants