Fix an issue with converting AM/PM time to 24 hour time. #2573
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
force-pushed
the
fix-conversion-to-24-hour-time
branch
from
c89a06c
to
e729556
Compare
The logic to convert to 24 hour time didn't consider 12am and 12pm correctly, this fixes that. This fixes issue openwebwork#2572
somiaj
force-pushed
the
fix-conversion-to-24-hour-time
branch
from
e729556
to
4ee8973
Compare
drgrice1
added a commit
that referenced
this pull request
Sep 24, 2024
…otfix Fix an issue with converting AM/PM time to 24 hour time (hotfix of #2573).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to convert to 24 hour time didn't consider 12am and 12pm correctly, this fixes that.
This fixes issue #2572