Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update date and version in webwork2.sty #2544

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

dlglin
Copy link
Member

@dlglin dlglin commented Aug 28, 2024

I'm assuming that we want to keep the version of webwork2.sty in sync with the version of WW.

I guess that this (and pg.sty in the pg repo) should probably be added to the release checklist. Does such a thing exist?

somiaj
somiaj previously approved these changes Aug 28, 2024
Copy link
Contributor

@somiaj somiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toomany places to update this version string....

@Alex-Jordan
Copy link
Contributor

I think this would be unnecessary if not for the bug about old LaTeX versions being fixed now. In other words, if nothing were changing in this sty file, I don't think we need to feel like updating this version number. I could have (should have?) just called it version 1 when it was born. And then version 2 would be the version with the recent change.

This needs a parallel PR into develop.

Alex-Jordan
Alex-Jordan previously approved these changes Sep 2, 2024
drgrice1
drgrice1 previously approved these changes Sep 2, 2024
Copy link
Sponsor Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to merge, but does need a corresponding develop PR. Do you want me to create that for you @dlglin?

@dlglin
Copy link
Member Author

dlglin commented Sep 3, 2024

This is ready to merge, but does need a corresponding develop PR. Do you want me to create that for you @dlglin?

Yes, that would be appreciated.

@somiaj
Copy link
Contributor

somiaj commented Sep 3, 2024

I'll create one for that.

@somiaj
Copy link
Contributor

somiaj commented Sep 3, 2024

I just noticed the author has a local email address, should this be changed or is this really @dlglin email address?

Author: Danny Glin <dlglin@Dannys-MacBook-Pro.local>

@drgrice1
Copy link
Sponsor Member

drgrice1 commented Sep 3, 2024

I created a pull request to develop.

The email should be updated for future pull requests!

@somiaj
Copy link
Contributor

somiaj commented Sep 3, 2024

I added one on the pg side.

@dlglin dlglin dismissed stale reviews from drgrice1, Alex-Jordan, and somiaj via 1b8bf48 September 3, 2024 18:38
@drgrice1 drgrice1 merged commit 12c2965 into openwebwork:main Sep 3, 2024
2 checks passed
drgrice1 added a commit that referenced this pull request Sep 3, 2024
Update date and version in webwork2.sty (#2544 for develop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants