-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update date and version in webwork2.sty #2544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toomany places to update this version string....
I think this would be unnecessary if not for the bug about old LaTeX versions being fixed now. In other words, if nothing were changing in this sty file, I don't think we need to feel like updating this version number. I could have (should have?) just called it version 1 when it was born. And then version 2 would be the version with the recent change. This needs a parallel PR into develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to merge, but does need a corresponding develop PR. Do you want me to create that for you @dlglin?
Yes, that would be appreciated. |
I'll create one for that. |
I just noticed the author has a local email address, should this be changed or is this really @dlglin email address?
|
I created a pull request to develop. The email should be updated for future pull requests! |
I added one on the pg side. |
1b8bf48
Update date and version in webwork2.sty (#2544 for develop)
I'm assuming that we want to keep the version of webwork2.sty in sync with the version of WW.
I guess that this (and pg.sty in the pg repo) should probably be added to the release checklist. Does such a thing exist?