Also set sub_status when giving credit with achievement items (hotfix of #2521) #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the progress bar reflects they have 'earned' full credit on the problems.
'Gives half credit' seems ambiguous, for it could mean set the score to 50% instead of increase the score by 50%. This updates the description to indicate the score is increased to a maximum of 100%.
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Aug 18, 2024
If an instructor increases a problem score using a problem grader, or an achievement item is used that increases the score, then the computed unreduced score can be greater than 1. This causes issues when that computed score is used at various places in the code (for example the progress bar). So this caps the computed score at 1. This is an alternate and better solution than openwebwork#2521 and openwebwork#2525.
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Aug 18, 2024
If an instructor increases a problem score using a problem grader, or an achievement item is used that increases the score, then the computed unreduced score can be greater than 1. This causes issues when that computed score is used at various places in the code (for example the progress bar). So this caps the computed score at 1. This is an alternate and better solution than openwebwork#2521 and openwebwork#2525.
somiaj
force-pushed
the
full-credit-update-sub-status-hotfix
branch
from
311a2bf
to
592eb2c
Compare
drgrice1
approved these changes
Aug 20, 2024
Alex-Jordan
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hotfix of #2521.