when copying sets from a new course and adding an instructor, assign … #2513
Conversation
|
I have a few more changes coming that have been motivated by recent experiences using 2.19 with PCC and Runestone. They could all have hotfix counterparts, but as with something before, I'm unsure if we are still doing that. Are we just rolling with more hotfixes through August? (That's fine with me.) |
Alex-Jordan
force-pushed
the
assign-to-new-instructor
branch
from
22d70d1
to
c28829b
Compare
|
If the changes are not too great and are something that we want to get in, then we can still hotfix. |
|
I reviewed the list of other things I have, and they are all either too big to accomplish anytime soon, or I think will be controversial. So please forget when I said:
|
Alex-Jordan
force-pushed
the
assign-to-new-instructor
branch
from
c28829b
to
a3789c2
Compare
|
Thanks, both this and the hotfix branch have the changes you suggested now. |
|
Just some comments in my testing of this. First I figured out that the first name, last name, and email address of this new prof that is being added are required (as I didn't include them and got an error), though the email address isn't validated for form, it just needs to be non blank. Not a big deal, but in comparison to adding a user inside a course only the username is needed, and nothing else is required. Second, What about assigning achievements to this new professor that are copied. I am unsure what would be preferable but am slightly on the side of not assigning them, I just thought I would mention this as well. |
Alex-Jordan
force-pushed
the
assign-to-new-instructor
branch
from
a3789c2
to
c3cf054
Compare
|
I made it so the achievements are also assigned to the new instructor. |
…all sets to that instructor
In 2.19, when you are creating a new course, you have the option to select an existing course and copy all of the sets into the new course. You also (as you've always been able to do) have the option of adding one "professor" level user to the new course. As things stand, the new professor will not have all of the copied sets assigned to them.
This commit changes it so that they will get all of those sets assigned to them.
I can't see a scenario where you want to copy sets from another course, but would not want them to be assigned to the new instructor. Maybe there is such a scenario. But I think it would be much more common to want that instructor to have everything assigned to them.