Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Romain dev from clean, towards 2.3.1 #217

Merged
merged 54 commits into from
Jun 25, 2024
Merged

Romain dev from clean, towards 2.3.1 #217

merged 54 commits into from
Jun 25, 2024

Conversation

romainphan
Copy link
Contributor

Main changes

  • Added bicubic reconstruction
  • added regularization parameters

Misc

  • in tuto 6, the path for saving files locally was written weirdly and always impoorted data from google drive (Double extension name in core.train #187), it is now corrected and only supports "xyz.pth" (which is the correct way)

@romainphan romainphan requested a review from nducros June 10, 2024 12:50
@romainphan
Copy link
Contributor Author

@nducros @tbaudier
do you think this could make a v2.3.1 ?

romainphan and others added 20 commits June 10, 2024 14:58
@romainphan
logged changes from future v2.3.1
6b4b9ba
@romainphan
included python autoformat
1ee3b87
@romainphan
Merge branch 'romain_dev_from_clean' of https://github.com/openspyrit…
4ea0728 
…/spyrit into romain_dev_from_clean
@romainphan
core.mea: included H1 in error msgs
a9ed13a
@romainphan
meas.test uses explicitly bilinear
33361ae
@pre-commit-ci
[pre-commit.ci] Automatic python formatting
f264653
@romainphan
fixed extension issue in tuto3
af1e0cc
@romainphan
core.meas device bug fix
11e9167
@romainphan
Merge branch 'romain_dev_from_clean' of https://github.com/openspyrit…
df899ea 
…/spyrit into romain_dev_from_clean
@pre-commit-ci
[pre-commit.ci] Automatic python formatting
1a54eeb
@romainphan
core.train path correction
d658193
@romainphan
tuto4 path correction
fa21284
@romainphan
in test_core_recon removed undeterministic test
ce6cc7f
@romainphan
Merge branch 'romain_dev_from_clean' of https://github.com/openspyrit…
c118f2e 
…/spyrit into romain_dev_from_clean
@pre-commit-ci
[pre-commit.ci] Automatic python formatting
befcd84
@romainphan
Merge branch 'master' of https://github.com/openspyrit/spyrit into ro…
e987802 
…main_dev_from_clean
@romainphan
Merge branch 'romain_dev_from_clean' of https://github.com/openspyrit…
4cd637b 
…/spyrit into romain_dev_from_clean
@romainphan
in meas integrated build_pinv for static classes
65bf2db
@romainphan
logged name change for function
52e422a
@romainphan
core.torch correctedswap Dx Dy
6e5fcf3
@nducros
Copy link
Member

nducros commented Jun 18, 2024 •
edited
Loading

See issue: #218

@nducros
Copy link
Member

nducros commented Jun 24, 2024

Thx !

  • Tuto 8 does not display well. Looks very good otherwise.

  • Can you add Michael in the loop, in particular for tuto 9 ?

@romainphan romainphan merged commit 7deaf8b into master Jun 25, 2024
30 checks passed
@romainphan romainphan deleted the romain_dev_from_clean branch June 26, 2024 08:44
@romainphan romainphan restored the romain_dev_from_clean branch June 26, 2024 09:40
@tbaudier tbaudier deleted the romain_dev_from_clean branch June 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nducros nducros Awaiting requested review from nducros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainphan @nducros