Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ART-10832] do not use reference nightlies for promotion #940

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Sep 17, 2024

Use the generated image stream to promote and not the reference nightlies, if they are present in the assembly. The reference nighlties should only be used for validation.

i.e. we should not use the --from-release param in oc adm release new

We probably need to update multi as well

Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ashwindasr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashwindasr ashwindasr force-pushed the embargo-fix branch 2 times, most recently from f150e84 to 4512332 Compare September 17, 2024 13:51
@ashwindasr ashwindasr changed the title fix embargo release do not use reference nightlies for promotion Sep 17, 2024
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

@ashwindasr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 648b17f link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ashwindasr ashwindasr changed the title do not use reference nightlies for promotion [ART-10832] do not use reference nightlies for promotion Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant