Also test with Groovy 2.5 on classpath for Gradle 4, 5 & 6 #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is getting frustrating; in an earlier iteration I'd seen these fail, but somehow it's not replicating right now. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Add an integration test source set using Groovy 2.5.x, and unit tests where we've seen failures on that version.
What's your motivation?
Make it easier detect & troubleshoot parser issues specific to Groovy 2.
Anything in particular you'd like reviewers to focus on?
Wasn't sure on the Java version required for this source set, since Java 16+ requires Groovy 3+.
Have you considered any alternatives or workarounds?
I'd also tried a separate rewrite-groovy-test module, which makes it easier to also set a lower required Java version, but didn't like adding yet another top level project if we can avoid it. Getting mixed results locally and having a bit of trouble with IDE. Figured open a draft to see results in CI.
Any additional context
We've seen an uptick in parser issues reported following some recent-ish changes