Parse .NET .vbproj and .fsproj files as XML #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryceatmoderne
changed the title
3 tasks
timtebeek
approved these changes
Sep 24, 2024
| // .NET project files | ||
| "csproj", | ||
| "vbproj", | ||
| "fsproj")); |
There was a problem hiding this comment.
I wonder if we also should add "targets" and "props" from the .NET ecosystem here or not. Thoughts?
There was a problem hiding this comment.
I think those were intentionally kept as plaintext, given any ambiguity in those file extensions being used elsewhere:
https://github.com/moderneinc/moderne-cli/pull/2117/files
There was a problem hiding this comment.
I see. So allowing these mappings to be more dynamic (e.g. parse .props files as XML in .NET projects) seems like it will at some point become necessary.
|
Already merging this now such that it makes it into today's release. Thanks both for your input! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
.vbprojand.fsprojare .NET project XML files and need to be parsed as such.What's your motivation?
Prior to these changes these file types were being parsed as
PlainText.Anything in particular you'd like reviewers to focus on?
No.
Anyone you would like to review specifically?
@timtebeek
Have you considered any alternatives or workarounds?
No.
Any additional context
No.
Checklist