Fix and test pipeline #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odscjames
reviewed
Jun 22, 2023
tests/test_pipeline.py
Outdated
| source = 'test-pipeline' | ||
|
|
||
| @pytest.fixture(scope="class") | ||
| def test_dir(self, tmp_path_factory): |
There was a problem hiding this comment.
Doesn't it confuse the runner to have a fixture started test_? Interesting. It confuses the human reader anyway, maybe for readability change?
There was a problem hiding this comment.
Seems to work, but have fixed for readability
odscjames
approved these changes
Jun 22, 2023
|
Approved, depending on whether you think that readability comment is important |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with parameter names in run_pipeline and add test of full pipeline run (less uploads) to catch future issues