Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-3002: Queue Module - REST endpoints can be accessed without authentication. #71

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

IamMujuziMoses
Copy link
Contributor

Issue I worked on

see https://issues.openmrs.org/browse/O3-3002

Checklist: I completed these to help reviewers :)

  • Added Authorized annotations to the service classes: QueueService, QueueEntryService, QueueRoomService and RoomProviderMapService.
  • Created PrivilegeConstants class to contain all privilege names and their descriptions.
  • Added liquibase changesets that will do a default assignment of these privileges to roles.

@chibongho
Copy link
Contributor

Thanks. This change looks reasonable. I'm not that familiar with permissions and liquibase, @dkayiwa @mseaton can you chime in here?

Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, nice work @IamMujuziMoses

@dkayiwa dkayiwa merged commit a6f91d0 into openmrs:main Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants