(fix):Filter Queue Entries to return count of those waiting for a ser… #62
Conversation
| // Filter queueEntries where ended_at is null. The count should be for those waiting for a service | ||
| List<QueueEntry> filteredQueueEntries = queueEntries.stream().filter(entry -> entry.getEndedAt() == null) | ||
| .collect(Collectors.toList()); | ||
|
|
There was a problem hiding this comment.
@makombe thanks for this PR. This endpoint does not make any assumptions about the metric being requested, and its intentionally kept generic. As you can see, it will run a search based on the request parameters passed into it, and then return the relevant count of those search results.
I assume this is attempting to fix invalid metric data on the frontend, in which case the simple fix would be to pass an additional parameter in the frontend request of isEnded=false. You can see the possible search criteria parameters in the QueueEntrySearchCriteriaParser.java class.
I recommend that we close this PR and instead make this fix in the service-queues app within patient managment.
|
@mseaton I think that is ok. I will close it and handle it on the frontend. |
…vice
Essentially the queue metrics count should only those waiting for a particular service and not those who have finished with a particular service. The counts should also match what is displayed on the table.