Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JavaFx platform configurable #103

Conversation

shahzaibj
Copy link

This PR Addresses #99

Platform can now be configured as follows:

image

@majerm
Copy link

majerm commented Jul 15, 2021

Thank you for PR. I need this functionality too. But mabye it is good write some lines to README file near section with name "4. Cross-platform projects and libraries".

@johanvos
Copy link
Contributor

This is good functionality. @jperedadnr can you review?

@jperedadnr
Copy link
Collaborator

@shahzaibj As per our contributions guidelines, could you please sign the CLA[https://cla.gluonhq.com/] before we can move forward with this PR?

@alaznem
Copy link

alaznem commented Nov 6, 2021

@shahzaibj As per our contributions guidelines, could you please sign the CLA[https://cla.gluonhq.com/] before we can move forward with this PR?

@shahzaibj : I came here from downstream as an user of the Sparrow wallet, where we're unable to build on Raspberry Pi 4 (arm) because of the JavaFx platform error solely. As @craigraw (the maintainer of sparrow) writes, your/this PR could solve our issues downstream.

As I got the current situation with this PR, the effort to be taken to move forward seems quite low to me: @jperedadnr has requested 3 months ago the singing of the CLA[https://cla.gluonhq.com/] from you.

❓ Could you please decide if you're able to sign the CLA[https://cla.gluonhq.com/] or not and communicate likewise?

🙏 Thanks

@FlorianKirmaier
Copy link
Contributor

push @shahzaibj

@SamB
Copy link

SamB commented Jul 15, 2022

... why just one platform, though?

@tycrek
Copy link

tycrek commented Apr 13, 2023

Bump for @shahzaibj on the CLA (this is now almost 2 years open).

@FlorianKirmaier
Copy link
Contributor

I made a functional identical PR quite some time ago, which also included another feature (configurable platform)

Why not just merge mine, instead of waiting for the CLA here?

I've already signed the CLA.

@johanvos
Copy link
Contributor

@FlorianKirmaier you mean #137?

@FlorianKirmaier
Copy link
Contributor

@johanvos
Yes, that is the PR I meant!

@abhinayagarwal
Copy link
Collaborator

superseded by #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants