-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make JavaFx platform configurable #103
Make JavaFx platform configurable #103
Conversation
Thank you for PR. I need this functionality too. But mabye it is good write some lines to README file near section with name "4. Cross-platform projects and libraries". |
This is good functionality. @jperedadnr can you review? |
@shahzaibj As per our contributions guidelines, could you please sign the CLA[https://cla.gluonhq.com/] before we can move forward with this PR? |
@shahzaibj : I came here from downstream as an user of the Sparrow wallet, where we're unable to build on Raspberry Pi 4 (arm) because of the JavaFx platform error solely. As @craigraw (the maintainer of sparrow) writes, your/this PR could solve our issues downstream. As I got the current situation with this PR, the effort to be taken to move forward seems quite low to me: @jperedadnr has requested 3 months ago the singing of the CLA[https://cla.gluonhq.com/] from you. ❓ Could you please decide if you're able to sign the CLA[https://cla.gluonhq.com/] or not and communicate likewise? 🙏 Thanks |
push @shahzaibj |
... why just one platform, though? |
Bump for @shahzaibj on the CLA (this is now almost 2 years open). |
I made a functional identical PR quite some time ago, which also included another feature (configurable platform) Why not just merge mine, instead of waiting for the CLA here? I've already signed the CLA. |
@FlorianKirmaier you mean #137? |
@johanvos |
superseded by #137 |
This PR Addresses #99
Platform can now be configured as follows: