Including common Non SFA functions #536
Conversation
Merge DWithin Pull Request content with Non SFA Functions
|
Valid points. @reference: |
| geof:aggCollect (geom: ogc:geomLiteral): ogc:geomLiteral | ||
| ``` | ||
|
|
||
| The function http://www.opengis.net/def/function/geosparql/aggCollect[`geof:aggCollect`] calculates creates a GeometryCollection literal out of a set of geometries. |
There was a problem hiding this comment.
Typo: "calculates creates"
There was a problem hiding this comment.
does geom: ogc:geomLiteral indicate that it's an array/set?
There was a problem hiding this comment.
It is a set of ogc:geomLiterals in practice likely bound to a SPARQL variable like in other functions too.
The content of the ogc:geomLiterals could be arrays, e.g. a WKT GeometryCollection could be considered as an array.
Does that answer your question or would you have a different idea how to mark an array/set?
There was a problem hiding this comment.
@situx I saw your answer in another issue that one geomLiteral can carry a collection.
But I think this is different: aggregates work on a resultset of multiple geomLiterals, so the function signature should indicate an array. Eg use geomLiteral*
There was a problem hiding this comment.
My comment is answered. But @mperry455 's comment not answered yet
|
I feel like geof:withinDistance reads a little better than geof:distanceWithin. |
|
Rename Simplify! :-) |
|
Discussed simplifyDP function. Given it's the only simplification function being considered currently, we arrived at the decision to call it just |
|
I applied all changes requested. With that we can re-review this pull request |
|
Would be good to get a few eyes on the options below. Please indicate your preferred options by using thumbs up. You can thumbs down if you're very much against an option. Can people add their thoughts to this before next meeting? Please indicate which option you like. All options require that we add an explanation in the explanatory notes section up top. |
|
|
|
|
Voting result: annotate as ogc:geomLiteral[] and add explanatory text to describe it. |
|
I added the array notation to all spatial aggregate functions, added a paragraph to explain the syntax and corrected some mistakes. The PR is therefore again ready for review. |
| @@ -1203,6 +1203,8 @@ Implementations shall support the functions | |||
| <<Function: geof:boundingCircle, `geof:boundingCircle`>>, | |||
| <<Function: geof:metricBuffer, `geof:metricBuffer`>>, | |||
| <<Function: geof:buffer, `geof:buffer`>>, | |||
| <<Function: geof:metricWithinDistance, `geof:metricWithinDistance`>>, | |||
| <<Function: geof:WithinDistance, `geof:WithinDistance`>>, | |||
There was a problem hiding this comment.
Lowercase 'w'? geof:withinDistance instead of geof:WithinDistance
|
|
||
| Returns true if `geom2` is within a given distance of `geom1`. Calculations are according to the units in the spatial reference system of `geom1`. The triple store implementation needs to take care of a conversion between meter and the unit of the spatial reference system. | ||
|
|
||
| ==== Function: geof:sfWithinDistance |
| @@ -57,6 +57,12 @@ The following IRI namespace prefixes are used throughout this document: | |||
|
|
|||
| All of these namespace prefixes in the previous section resolve to resources that contain their namespace content except for `eg:` (`http://example.com/`), which is used just for examples, and `ogc:` (`http://www.opengis.net/`), which is used in requirement specifications as a placeholder for the geometry literal serialization used in a fully-qualified conformance class, e.g. http://www.opengis.net/ont/geosparql#wktLiteral[`+<http://www.opengis.net/ont/geosparql#wktLiteral>+`]. | |||
|
|
|||
| === Data Types for Spatial Aggregate Functions | |||
|
|
|||
| In this specification we use the placeholder URI ogc:geomLiteral to describe any geometry literal which is defined in this specification. | |||
| === Data Types for Spatial Aggregate Functions | ||
|
|
||
| In this specification we use the placeholder URI ogc:geomLiteral to describe any geometry literal which is defined in this specification. | ||
| To express a list of such literals, for example as input parameters for spatial aggregate functions, we use the notation ogc:geomLiteral[]. |
There was a problem hiding this comment.
don't you need to put ogc:geomLiteral[] in some code markers? (I'm not familiar with adoc)
|
|
||
| In this specification we use the placeholder URI ogc:geomLiteral to describe any geometry literal which is defined in this specification. | ||
| To express a list of such literals, for example as input parameters for spatial aggregate functions, we use the notation ogc:geomLiteral[]. | ||
| We do not define the order of ogc:geomLiteral[]. The order is to be determined by implementers. |
There was a problem hiding this comment.
I don't understand that. A "list" is ordered, so how do you mean implementers can change it?
| distance: xsd:double): xsd:boolean | ||
| ``` | ||
|
|
||
| Returns true if `geom2` is within a given distance of `geom1`. Calculations are according to the units in the spatial reference system of `geom1`. The triple store implementation needs to take care of a conversion between meter and the unit of the spatial reference system. |
There was a problem hiding this comment.
"given distance of geom1" -> add "in meters"
| geof:aggCollect (geom: ogc:geomLiteral): ogc:geomLiteral | ||
| ``` | ||
|
|
||
| The function http://www.opengis.net/def/function/geosparql/aggCollect[`geof:aggCollect`] calculates creates a GeometryCollection literal out of a set of geometries. |
There was a problem hiding this comment.
My comment is answered. But @mperry455 's comment not answered yet
Closes #257
Closes #341
Closes #400