Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chris little metanormapatch 1 #42

Merged
merged 10 commits into from
Sep 14, 2023
Merged

Conversation

chris-little
Copy link
Contributor

Fully compliant with metanorma, I think.

@cmheazel
Copy link
Collaborator

cmheazel commented Sep 8, 2023

The nofetch directives are in there for a reason. The citation fetching capabilities of Metanorma are very fragile. Rather than spending hours trying to get them to work, I just disable them. In the case of this pull request, Metanorma crashes trying to reference RFC 3339. On my machine, no PDF (or any other format) is generated.

@chris-little
Copy link
Contributor Author

chris-little commented Sep 12, 2023

The nofetch directives are in there for a reason. The citation fetching capabilities of Metanorma are very fragile. Rather than spending hours trying to get them to work, I just disable them. In the case of this pull request, Metanorma crashes trying to reference RFC 3339. On my machine, no PDF (or any other format) is generated.

@cmheazel On my machine, the (nofetch) text was not suppressed and appeared in the PDF. When I inspected the build logs, there were no crashes from the relaton look-ups. In particular:
[relaton-ietf] ("IETF RFC 3339") found RFC 3339. Maybe the bug is now fixed?

@chris-little chris-little requested a review from a team September 12, 2023 16:18
@chris-little chris-little merged commit a02bbb1 into master Sep 14, 2023
2 checks passed
@chris-little chris-little deleted the chris-little-metanormapatch-1 branch September 14, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants