build: use shared browserslist config and remove is-es5 check #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 88.63% 88.63%
=======================================
Files 68 68
Lines 906 906
Branches 243 243
=======================================
Hits 803 803
Misses 96 96
Partials 7 7 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Jawayria
force-pushed
the
bseverino/shared-browserslist-config
branch
from
8c0b886
to
3ae51b6
Compare
UsamaSadiq
approved these changes
Jun 6, 2022
|
@UsamaSadiq, do you mind resolving conflicts, please? I'll try and review/merge as soon as you do. Thanks! |
|
I meant to ask @bseverino, actually. Sorry. :) |
|
Closing for inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openedx/wg-frontend#47
is-es5check in CI since ES5 was only needed for IE 11 support which is dropped. The supported browsers defined by the shared configuration all natively support ES6.This PR is dependent on the Node 16 upgrade. See this document for upgrade status.