Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use shared browserslist configuration and upgrade paragon version #649

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Dec 12, 2022

Ticket:
Use shared @edx/browserslist-config

  • Removes custom browserslist configuration in favor of using a shared configuration.
  • Removes is-es5 check in CI since ES5 was only needed for IE 11 support which is dropped. The supported browsers defined by the shared configuration all natively support ES6.

This change reduces the resultant asset bundle size.

  • Update edx/paragon version

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 65.14% // Head: 65.14% // No change to project coverage 👍

Coverage data is based on head (8d99045) compared to base (42a0d27).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   65.14%   65.14%           
=======================================
  Files          47       47           
  Lines         809      809           
  Branches      156      156           
=======================================
  Hits          527      527           
  Misses        272      272           
  Partials       10       10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mashal-m
Copy link
Contributor Author

Review Requested here

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches what's being done across the board. +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants