build: Upgrade to Node 20 #847
Conversation
.github/workflows/ci.yml
Outdated
| @@ -12,17 +12,18 @@ jobs: | |||
| matrix: | |||
| python-version: ['3.8', '3.12'] | |||
| django-version: ['4.2'] | |||
| node: [18] | |||
There was a problem hiding this comment.
In the issue for updating all MFEs there is an example PR that configures the ci.yml file so that the workflow is run with both Node 18 and Node 20. Is this no longer the recommended pattern?
There was a problem hiding this comment.
I have discussed this in FWG and the one you mentioned is the recommended pattern. I'm going to draft this for now and wait for prerequisite PR to get merged
|
PR will be updated and ready for review once the prerequisite PR for first step of the node v20 upgrade process is merged. |
…into bilalqamar95/node-v20-upgrade
|
Hey @BilalQamar95 , this week I'll be reviewing this PR. Would you mind resolving the package-lock.json conflict? |
…into bilalqamar95/node-v20-upgrade
@jsnwesson I have resolved the conflicts |
Description
package-lock.jsonwith nodev20and NPM10..nvmrcwith nodev20ciworkflow switched to dynamically set the Node.js version from.nvmrc.lockfileversion check workflowSecond step in the Node 20 upgrade process, See the tracking issue for further information.