Parse Patch and Source lines more accurately #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmueller
force-pushed
the
better_source_parsing
branch
from
a3285d4
to
e478401
Compare
rpm(1) actually parses Patch and Source lines in a special way, it can skip over any non-whitespace until the next ':' as part of the patch suffix determination. So things like Source42 foo: https://host/domain/file.tar.gz are now parsed as well.
dirkmueller
force-pushed
the
better_source_parsing
branch
from
e478401
to
175ea22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpm(1) actually parses Patch and Source lines in a special way, it can skip over any non-whitespace until the next ':' as part of the patch suffix determination.
So things like
Source foo: https://host/domain/file.tar.gz
are possible and need to be parsed properly.