Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - data fusion support #91

Merged
merged 23 commits into from
Nov 23, 2023
Merged

Feature - data fusion support #91

merged 23 commits into from
Nov 23, 2023

Conversation

zansinergise
Copy link
Collaborator

@zansinergise
Set multiple inputs and mark what still needs to be fixed
4693b61
@zansinergise
Fix stuff mostly related to input bands
1a20864
@zansinergise
Fix names if length of nodes is 0
1f00d93
@zansinergise
fix bug
1aca9e0
@zansinergise
add safety check for scenes which are undefined (probably wrong)
14a196e
@zansinergise
run linting
8d75ab4
@zansinergise
fix bug where there were no input bands set
e6774a3
@zansinergise
add comment what to fix
5b2655d
@zansinergise
fix updateOutput function if multiple load collections
b67ec31
@zansinergise
run linting
a42c324
@zansinergise
should work for both basic and fusion
604de6a
@zansinergise
fix failing tests, so results match the processes https://processes.o…
40d5580 
…peneo.org/#order
@zansinergise
fix wrong concatenation
c7bf92b
@zansinergise
fix so correct samples are used for datacube creation
e40aaad
@zansinergise
make bands_metadata use the new correct format
ee911c9
@zansinergise
fix failing tests so they match new format of input bands
3531d7b
@zansinergise
revert changes in order test
0215634
@zansinergise
fix bug
d248eec
@zansinergise
remove comment as execution order is ok
f0c4f57
@zansinergise
fix for even more advanced PGs
128d18d
@zcernigoj zcernigoj self-assigned this Nov 21, 2023
zcernigoj
zcernigoj requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@zcernigoj zcernigoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty ok. I would make some changes and I'm not sure about the band names not being split by datasource. See comments for details

@zcernigoj zcernigoj assigned zansinergise and unassigned zcernigoj Nov 21, 2023
@zcernigoj zcernigoj mentioned this pull request Nov 22, 2023
Open
@zcernigoj zcernigoj assigned zansinergise and unassigned zcernigoj Nov 22, 2023
@zcernigoj zcernigoj assigned zansinergise and unassigned zcernigoj Nov 23, 2023
@zansinergise zansinergise merged commit d7fda12 into master Nov 23, 2023
2 checks passed
@zansinergise zansinergise deleted the feature/data_fusion_support branch November 23, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcernigoj zcernigoj zcernigoj approved these changes

Assignees

@zansinergise zansinergise

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zansinergise @zcernigoj