-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance accessibilty and seo for hero section #529
base: beta
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
✅ Deploy Preview for hot-sauced-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @sohaibchebah! Please read the contributing guidelines above. |
This PR adds more accessibility to the hero section and also seo bost becuase search engine crawlers understand more the semantic html feat open-sauced#530
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making things more accessible @sohaibchebah!
<section | ||
aria-labelledby="hero-heading" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactor (blocking): assistive technologies know how to pick up the header within the section, so no need for aria.
<section | |
aria-labelledby="hero-heading" | |
<section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for the information 😊
className="font-Lexend text-4xl md:text-5xl text-center text-lightSlate leading-tight tracking-tight" | ||
id="hero-heading" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactor (blocking): not required base on comment above.
id="hero-heading" |
Description
This PR adds more accessibility to the hero section and also seo bost becuase search engine crawlers understand more the semantic html
Related Tickets & Documents
Closes #530
Mobile & Desktop Screenshots/Recordings
N/A
Steps to QA
N/A
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?