Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Load more button visibility issue and now loads data upon clicking #478

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

deepakrudrapaul
Copy link
Contributor

Description

This PR fixes the load more button visibility issue and now loads data upon clicking

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #446

Mobile & Desktop Screenshots/Recordings

Before :
before.webm

After :
after.webm

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

😃

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for hot-sauced-ui ready!

Name Link
🔨 Latest commit 3679c82
🔍 Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/64b81a45f574620008060b13
😎 Deploy Preview https://deploy-preview-478--hot-sauced-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

Copy link
Contributor

@NsdHSO NsdHSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/components/ListRepositories.tsx Show resolved Hide resolved
@bdougie
Copy link
Member

bdougie commented Aug 10, 2023

Sorry for missing this one. Looks good

@bdougie bdougie merged commit 43f1fb0 into open-sauced:beta Aug 11, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
## [2.33.1-beta.3](v2.33.1-beta.2...v2.33.1-beta.3) (2023-08-11)

### 🐛 Bug Fixes

* Load more button visibility issue  and now loads data upon clicking ([#478](#478)) ([43f1fb0](43f1fb0))
@github-actions
Copy link

🎉 This PR is included in version 2.33.1-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bdougie bdougie mentioned this pull request Aug 11, 2023
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
## [2.33.1](v2.33.0...v2.33.1) (2023-08-11)

### 🐛 Bug Fixes

* Footer position on initial render ([#474](#474)) ([676477d](676477d))
* Load more button visibility issue  and now loads data upon clicking ([#478](#478)) ([43f1fb0](43f1fb0))
* Styled input field ([#475](#475)) ([4f2d743](4f2d743))
@github-actions
Copy link

🎉 This PR is included in version 2.33.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Should not show load more button if there is no more data
3 participants