Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Styled input field #475

Merged
merged 3 commits into from
Jul 15, 2023
Merged

fix: Styled input field #475

merged 3 commits into from
Jul 15, 2023

Conversation

Sadeedpv
Copy link
Contributor

@Sadeedpv Sadeedpv commented Jul 10, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Icons in the input field of the hero section in the page could be aligned with a simple flex and modifying tailwind-css at line 76 and adding an extra div at line 77;

Related Tickets & Documents

Fixes #473

Mobile & Desktop Screenshots/Recordings

Before:

before

After:

PR

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Jul 10, 2023

βœ… Deploy Preview for hot-sauced-ui ready!

Name Link
πŸ”¨ Latest commit 65a4163
πŸ” Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/64b1250baf99f4000973cc9c
😎 Deploy Preview https://deploy-preview-475--hot-sauced-ui.netlify.app/
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Sadeedpv Sadeedpv changed the title Styled input field fix: Styled input field Jul 10, 2023
@bdougie
Copy link
Member

bdougie commented Jul 10, 2023

@Sadeedpv can you share a before and after?

src/components/Hero.tsx Outdated Show resolved Hide resolved
@Sadeedpv
Copy link
Contributor Author

Please merge this PR

@Sadeedpv Sadeedpv requested a review from bdougie July 12, 2023 10:48
Copy link
Contributor

@takanome-dev takanome-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good πŸ‘ Just some tweaks and this should be good to go

The searchNormal icon is bigger and there is not enough space between the icon and the search input

src/components/Hero.tsx Outdated Show resolved Hide resolved
src/components/Hero.tsx Outdated Show resolved Hide resolved
Sadeedpv and others added 2 commits July 14, 2023 16:05
Co-authored-by: El Hadji Malick Seck <takanomedev221@gmail.com>
Co-authored-by: El Hadji Malick Seck <takanomedev221@gmail.com>
Copy link
Contributor

@NsdHSO NsdHSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Sorry for being out of context, can you add here fetchedData?.length

Copy link
Contributor

@takanome-dev takanome-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdougie bdougie merged commit 4f2d743 into open-sauced:beta Jul 15, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 15, 2023
## [2.33.1-beta.1](v2.33.0...v2.33.1-beta.1) (2023-07-15)

### πŸ› Bug Fixes

* Styled input field ([#475](#475)) ([4f2d743](4f2d743))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 2.33.1-beta.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@bdougie bdougie mentioned this pull request Aug 11, 2023
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
## [2.33.1](v2.33.0...v2.33.1) (2023-08-11)

### πŸ› Bug Fixes

* Footer position on initial render ([#474](#474)) ([676477d](676477d))
* Load more button visibility issue  and now loads data upon clicking ([#478](#478)) ([43f1fb0](43f1fb0))
* Styled input field ([#475](#475)) ([4f2d743](4f2d743))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 2.33.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Icons in the input field of the hero section could be aligned
4 participants