Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with useful commands and tips #14

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Update README.md with useful commands and tips #14

merged 4 commits into from
Aug 12, 2024

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Aug 9, 2024

  • The first step to making these docs easy for others to develop
  • Update submodule pointer to more recent commit

I request review from Brandon particularly in case I missed anything.
I request review from Jon because he has yet to build these docs. These instructions must be sufficient to enable him to do that or they need to be amended.

- The first step to making these docs easy for others to develop
- Update submodule pointer to more recent commit
@cjsha cjsha requested review from jonnew and bparks13 August 9, 2024 15:40
Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, very nice way to help people through the configuration process. Feel free to add in my suggestions, but I think this would be good enough as is, not everyone needs to fully understand how to test but I think it's useful to have it documented.

README.md Outdated Show resolved Hide resolved
README.md Outdated

To make the `docfx` command available after restoring the config file from the previous step, run:

`dotnet tool restore`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only line I'm not sure is needed, doesn't the previous restore command pull everything in already?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to run dotnet docfx after running the previous restore command for the first time, it prints this:

Screenshot 2024-08-09 131211

I think you're right though. I don't think I should have to run dotnet tool restore again. dotnet might not be restoring correctly on my system when I run the first restore command. Something's amiss.

README.md Show resolved Hide resolved
- Add instructions for doing the linkcheck commands before pushing
- Add brief explainer on what the `dotnet docfx` command does
- Add info on how to easily produce more bonsai screenshots
@cjsha
Copy link
Member Author

cjsha commented Aug 12, 2024

Jon made a comment to me:
use triple back ticks to highlight git commands and get copy button.

Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some edits in my latest commit, but looks good

@cjsha
Copy link
Member Author

cjsha commented Aug 12, 2024

@jonnew read this section of the readme about linkchecks. I can fix the broken references in the meanwhile though, if you'd like. Let me know

@cjsha
Copy link
Member Author

cjsha commented Aug 12, 2024

Good edits. I added two comments that might clarify the initialization process which we were kinda confused about it earlier.

- Also fix broken references
@cjsha cjsha merged commit 50d30e0 into main Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants