This repository has been archived by the owner on Dec 21, 2021. It is now read-only.
Fix content type parsing error for HttpCore 4.4.6+ #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting this fork for the same reason as #5.
A bugfix in Apache HttpCore 4.4.6 (HTTPCORE-423, f8f55e88) causes UrlRewriteFilter PUT/POST requests to fail if their content type includes a charset (e.g.,
Content-Type: application/json; charset=UTF-8
). This is because theContentType.create(String)
method used to use its parameter directly as the MIME type (incorrect behavior -- included charset in MIME type), but now tries to read it as a MIME type. The alternative factory methodContentType.parse(String)
parses the full string for both MIME type and charset.We didn't notice this issue until recently since we don't pull transitive dependencies for UrlRewriteFilter. A separate library update upgraded us from HttpCore v4.4.5 to v4.4.13, which fixed the
ContentType.create(String)
method but broke UrlRewriteFilter.