-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samples viewer #50
base: main
Are you sure you want to change the base?
Samples viewer #50
Conversation
0512521
to
9757ef7
Compare
@will-moore: what's the best way to review? Is there a URL somewhere? |
We need to activate netlify to build it, same as for ngff-validator... You have an OME account for netlify? |
@joshmoore Need to somehow point netlify at the |
I think it's maybe trying to build the |
✅ Deploy Preview for euphonious-mochi-664405 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
OK, I got it to deploy at https://66e06a54f9201459706a0106--ome2024-ngff-challenge.netlify.app/?csv=https://raw.githubusercontent.com/will-moore/ome2024-ngff-challenge/samples_viewer/samples/ngff_samples.csv Some of the key settings (apart from specifying to just use build this branch from my repo):
|
@joshmoore That doesn't look quite right. I think it's the same problem I had initially - serving src etc instead of from |
Also, you can give the netlify app a name instead of the random one it generates. I think I might have claimed |
234f97f
to
2c89d47
Compare
@sbesson suggested during the call adding a "provider" or "source" column to the default view. Thinking of the implementation of that, @will-moore, Can we have:
i.e., no mixing at the top-level? |
After that commit: loading ro-crate-metadata.json (on user request, so as not to make too many requests initially). |
add Webknossos samples
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
df37e12
to
fa70efe
Compare
912835b
to
3248605
Compare
Work in progress; Exploring options for showing summary of sample data.
Deployed at e.g. https://samples-viewer--ome2024-ngff-challenge.netlify.app/?csv=https://raw.githubusercontent.com/will-moore/ome2024-ngff-challenge/samples_viewer/samples/idr0157_samples.csv
You can update the query string to point at any other csv, which simply expects a URL on each row.
There is a web page that loads the "master" csv via query string
?csv=https://raw.githubusercontent.com/will-moore/ome2024-ngff-challenge/samples_viewer/samples/ngff_samples.csv
and recursively follows links to any other csvs.Web page is a Svelte.js app - probably a bit of an overkill just now, but makes it easier to grow.
Currently, we display data like this (screenshot below) - Some of the earlier samples here don't have
written
bytes info as that came later.Questions etc: We need to make a bunch of http requests for each sample row in the table, and we are currently ONLY loading the highest resolution array - bytes written to other resolutions are ignored:
0
from first well), array0
only), arrayNot yet loading:
This approach gives a nice summary for a reasonable number of samples, but in it's current form it won't scale very nicely for all the data we're planning to show. E.g, it will take a long time to get summary data for all the samples.
We could probably load the URLs for all samples (load ALL the CSVs) and say "10k samples" and then load the samples themselves incrementally, e.g. as you scroll through the list, or random slide-show etc.
NB: I have got netlify to deploy from this branch. Need to get OME's netlify to deploy from main once merged.
See screenshots below for latest changes...