-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Collection Manager OMVS #8130
Conversation
Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
public VoidResponse removeFromCollection(String serverName, | ||
String collectionGUID, | ||
String elementGUID, | ||
NullRequestBody requestBody) |
Check notice
Code scanning / CodeQL
Useless parameter Note
@SuppressWarnings(value = "unused") | ||
public VoidResponse deleteCollection(String serverName, | ||
String collectionGUID, | ||
NullRequestBody requestBody) |
Check notice
Code scanning / CodeQL
Useless parameter Note
public VoidResponse detachCollection(String serverName, | ||
String collectionGUID, | ||
String parentGUID, | ||
NullRequestBody requestBody) |
Check notice
Code scanning / CodeQL
Useless parameter Note
|
||
PreparedStatement preparedStatement = jdbcConnection.prepareStatement(sqlCommand1); | ||
PreparedStatement preparedStatement = jdbcConnection.prepareStatement(pg_statsSQLCommand); |
Check warning
Code scanning / CodeQL
Potential database resource leak Warning
|
||
ResultSet resultSet = preparedStatement.executeQuery(); | ||
|
||
final String pg_tablesSQLCommand = "SELECT schemaname, tablename, tableowner, tablespace, hasindexes, hasrules, has_triggers from pg_tables;"; | ||
|
||
preparedStatement = jdbcConnection.prepareStatement(pg_statsSQLCommand); |
Check warning
Code scanning / CodeQL
Potential database resource leak Warning
|
||
jdbcConnection.getMetaData(); | ||
resultSet = preparedStatement.executeQuery(); |
Check warning
Code scanning / CodeQL
Potential database resource leak Warning
* | ||
* @return map of string to string | ||
*/ | ||
public Map<String, String> getOtherPropertyValues() |
Check notice
Code scanning / CodeQL
Exposing internal representation Note
after this call to getOtherPropertyValues
|
||
ResultSet resultSet = preparedStatement.executeQuery(); | ||
|
||
final String pg_tablesSQLCommand = "SELECT schemaname, tablename, tableowner, tablespace, hasindexes, hasrules, has_triggers from pg_tables;"; |
Check notice
Code scanning / CodeQL
Unread local variable Note
} | ||
|
||
|
||
static class ColumnDetails |
Check notice
Code scanning / CodeQL
Unused classes and interfaces Note
@@ -139,4 +145,25 @@ | |||
|
|||
super.disconnect(); | |||
} | |||
|
|||
|
|||
static class schemaDetails |
Check notice
Code scanning / CodeQL
Unused classes and interfaces Note
Description
This PR includes the initial implementation of the Collection Manager OMVS.
Related Issue(s)
There is also a fix to the Automated Curation OMVS methods
getEngineActionsByName
andfindEngineActions
. The underlying client from the Open Governance Server was issuing an HTTP GET rather than an HTTP POST.Testing
FVT
Release Notes & Documentation
A new page has been created on egeria docs for this OMVS
Additional notes