Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Collection Manager OMVS #8130

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

mandy-chessell
Copy link
Contributor

Description

This PR includes the initial implementation of the Collection Manager OMVS.

Related Issue(s)

There is also a fix to the Automated Curation OMVS methods getEngineActionsByName and findEngineActions. The underlying client from the Open Governance Server was issuing an HTTP GET rather than an HTTP POST.

Testing

FVT

Release Notes & Documentation

A new page has been created on egeria docs for this OMVS

Additional notes

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
@mandy-chessell mandy-chessell merged commit 9774b6f into odpi:main Apr 3, 2024
4 checks passed
public VoidResponse removeFromCollection(String serverName,
String collectionGUID,
String elementGUID,
NullRequestBody requestBody)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'requestBody' is never used.
@SuppressWarnings(value = "unused")
public VoidResponse deleteCollection(String serverName,
String collectionGUID,
NullRequestBody requestBody)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'requestBody' is never used.
public VoidResponse detachCollection(String serverName,
String collectionGUID,
String parentGUID,
NullRequestBody requestBody)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'requestBody' is never used.

PreparedStatement preparedStatement = jdbcConnection.prepareStatement(sqlCommand1);
PreparedStatement preparedStatement = jdbcConnection.prepareStatement(pg_statsSQLCommand);

Check warning

Code scanning / CodeQL

Potential database resource leak Warning

This PreparedStatement is not always closed on method exit.

ResultSet resultSet = preparedStatement.executeQuery();

final String pg_tablesSQLCommand = "SELECT schemaname, tablename, tableowner, tablespace, hasindexes, hasrules, has_triggers from pg_tables;";

preparedStatement = jdbcConnection.prepareStatement(pg_statsSQLCommand);

Check warning

Code scanning / CodeQL

Potential database resource leak Warning

This PreparedStatement is not always closed on method exit.

jdbcConnection.getMetaData();
resultSet = preparedStatement.executeQuery();

Check warning

Code scanning / CodeQL

Potential database resource leak Warning

This ResultSet is not always closed on method exit.
*
* @return map of string to string
*/
public Map<String, String> getOtherPropertyValues()

Check notice

Code scanning / CodeQL

Exposing internal representation Note

getOtherPropertyValues exposes the internal representation stored in field otherPropertyValues. The value may be modified
after this call to getOtherPropertyValues
.

ResultSet resultSet = preparedStatement.executeQuery();

final String pg_tablesSQLCommand = "SELECT schemaname, tablename, tableowner, tablespace, hasindexes, hasrules, has_triggers from pg_tables;";

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'String pg_tablesSQLCommand' is never read.
}


static class ColumnDetails

Check notice

Code scanning / CodeQL

Unused classes and interfaces Note

Unused class: ColumnDetails is not referenced within this codebase. If not used as an external API it should be removed.
@@ -139,4 +145,25 @@

super.disconnect();
}


static class schemaDetails

Check notice

Code scanning / CodeQL

Unused classes and interfaces Note

Unused class: schemaDetails is not referenced within this codebase. If not used as an external API it should be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant