Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oasis Integration #1837

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Oasis Integration #1837

wants to merge 10 commits into from

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Aug 22, 2024 •
edited
Loading

Fixes # .

Changes proposed in this PR:

@mariacarmina mariacarmina self-assigned this Aug 22, 2024
@mihaisc
Copy link
Contributor

mihaisc commented Sep 2, 2024 •
edited
Loading

  • add tests
  • add FileObject in datatoken4 constructor(in contract, not as a separate tx).
  • remove addConsumer, checkConsumer, private functions
  • remove getFileObject
  • integration with Oasis SDK not existing for: constructor, setFileObject

@codeclimate CodeClimate
Copy link

codeclimate bot commented Sep 3, 2024

Code Climate has analyzed commit f751cc2 and detected 9 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 8

Note: there is 1 critical issue.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.7% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc will be requested when the pull request is marked ready for review mihaisc is a code owner

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 will be requested when the pull request is marked ready for review alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas will be requested when the pull request is marked ready for review bogdanfazakas is a code owner

@paulo-ocean paulo-ocean Awaiting requested review from paulo-ocean paulo-ocean will be requested when the pull request is marked ready for review paulo-ocean is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 will be requested when the pull request is marked ready for review jamiehewitt15 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariacarmina @mihaisc