Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update CrossSellCad click event to be in button #1072

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

danimuller20
Copy link
Contributor

@danimuller20 danimuller20 commented Jun 19, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Screenshots (if appropriate):

Checklist:

  • I have read the CONTRIBUTING document
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • My changes work in Chrome, Edge, and Firefox
  • [] I have made corresponding changes to the documentation (if appropriate)
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (70870f0) 100.00% compared to head (6e4a68e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1072   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        58           
  Lines         1099      1098    -1     
  Branches       341       341           
=========================================
- Hits          1099      1098    -1     
Impacted Files Coverage Δ
...es/ocean-react/src/CrossSellCard/CrossSellCard.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danimuller20 danimuller20 merged commit 3e84280 into master Jun 22, 2023
11 checks passed
@danimuller20 danimuller20 deleted the fix/cross-sell-card-click branch June 22, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants