Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 packages from ocsigen/lwt at 5.8.0 #26668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raphael-proust
Copy link
Collaborator

This pull-request concerns:

  • lwt.5.8.0: Promises and event-driven I/O
  • lwt_ppx.5.8.0: PPX syntax for Lwt, providing something similar to async/await from JavaScript


🐫 Pull-request generated by opam-publish v2.4.0

@raphael-proust
Copy link
Collaborator Author

The only CI errors I see are:

  • some misc revdeps (curl timeout, hash mismatch, generic build fail, etc.)
  • some jailing issue in macos (networking syscalls failing during the tests)
  • also jailing issues(?) or some other system issue(?) on freebsd

As far as I'm concerned, this is ready to merge.

@hannesm
Copy link
Member

hannesm commented Oct 4, 2024

I'm only worried a bit about the following error:

#=== ERROR while compiling lambda-term.3.3.2 ==================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/lambda-term.3.3.2
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p lambda-term -j 255 @install
# exit-code            1
# env-file             ~/.opam/log/lambda-term-7-dfcc94.env
# output-file          ~/.opam/log/lambda-term-7-dfcc94.out
### output ###
# File "src/dune", line 11, characters 11-27:
# 11 |     (names lTerm_term_stubs lTerm_unix_stubs lTerm_windows_stubs)
#                 ^^^^^^^^^^^^^^^^
# (cd _build/default/src && /usr/bin/gcc -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC -D_FILE_OFFSET_BITS=64 -g -I /home/opam/.opam/4.14/lib/ocaml -I /home/opam/.opam/4.14/lib/bytes -I /home/opam/.opam/4.14/lib/logs -I /home/opam/.opam/4.14/lib/lwt -I /home/opam/.opam/4.14/lib/lwt/unix -I /home/opam/.opam/4.14/lib/lwt_react -I /home/opam/.opam/4.14/lib/mew -I /home/opam/.opam/4.14/lib/mew_vi -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ocplib-endian/bigstring -I /home/opam/.opam/4.14/lib/react -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/trie -I /home/opam/.opam/4.14/lib/uchar -I /home/opam/.opam/4.14/lib/uucp -I /home/opam/.opam/4.14/lib/uuseg -I /home/opam/.opam/4.14/lib/uutf -I /home/opam/.opam/4.14/lib/zed -o lTerm_term_stubs.o -c lTerm_term_stubs.c)
# In file included from lTerm_term_stubs.c:10:
# /home/opam/.opam/4.14/lib/lwt/unix/lwt_unix.h:19:28: error: expected declaration specifiers or '...' before '(' token
#    19 |     caml_convert_flag_list((flags), (int *)(table))
#       |                            ^
# /home/opam/.opam/4.14/lib/ocaml/caml/alloc.h:60:16: note: in expansion of macro 'caml_convert_flag_list'
#    60 | CAMLextern int caml_convert_flag_list (value, int *);
#       |                ^~~~~~~~~~~~~~~~~~~~~~
# /home/opam/.opam/4.14/lib/lwt/unix/lwt_unix.h:19:37: error: expected declaration specifiers or '...' before '(' token
#    19 |     caml_convert_flag_list((flags), (int *)(table))
#       |                                     ^
# /home/opam/.opam/4.14/lib/ocaml/caml/alloc.h:60:16: note: in expansion of macro 'caml_convert_flag_list'
#    60 | CAMLextern int caml_convert_flag_list (value, int *);
#       |                ^~~~~~~~~~~~~~~~~~~~~~

I'm not sure what is the root cause, but it looks like lwt_unix.h usage of caml_convert_flag_list doesn't play nicely (anymore?)? is this a regression?

For FreeBSD failures, these seem to be test failures. Not sure whether they're meant to succeed (or did succeed in earlier releases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants