-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package zarr v0.1.0 #26462
Package zarr v0.1.0 #26462
Conversation
@mseri Not sure what else I need to pass the tests. Any suggestions? Note that I have no interest in supporting Windows so the failed CI on that platform is irrelevant as far as i'm concerned. |
Hi. Thanks for publishing the package! The Window failure is from the owl dep, and not this package, so no reason to exclude windows in the
However the failures on linux should probably be fixed. E.g.,
|
The PR zoj613/zarr-ml#68 should fix the issue with the tests |
3f4586e
to
a8c0e4a
Compare
I am working on a PR to get rid of the Owl dependency since the only functionality I use from it is very basic operations that could be implemented in a self-contained module. That should get rid of the Windows build failure. In the meantime I updated the package archive checksums to include the commit fixing the linux failures (hopefully). |
Nice! All ocaml-ci is either passing or skipped now, with the exception of the name collision check, which is not flagging any relevant concerns. Let us know when you are ready for us to move forward. |
@zoj613 if that's all right with you, we can merge |
a8c0e4a
to
8cf3340
Compare
Please go ahead and merge. |
Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an |
This pull-request concerns:
zarr.0.1.0
: An Ocaml implementation of the Zarr V3 storage format specificationzarr-eio.0.1.0
: Eio-aware API for Zarrzarr-lwt.0.1.0
: Lwt-aware API for Zarrzarr-sync.0.1.0
: Synchronous API for Zarr🐫 Pull-request generated by opam-publish v2.4.0