Vanilla Inputs.file #266
Merged
Vanilla Inputs.file #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do we document the change for people who used fileOf (maybe the only one who did so was the unit test :-) ). |
|
I don’t think we need to say anything else. It was an internal method. |
|
I think this is a nice improvement to the usability of Inputs in a vanilla context, and offers a cleaner separation to avoid the circular dependency between Inputs and the Observable standard library. What do you think, @Fil? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For observablehq/framework#1608, also makes Inputs.file usable “out of the box” albeit with a vanilla File instead of an Observable FileAttachment, but that seems reasonable.