Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image_template: enable image template version name #733

Merged
merged 3 commits into from
Dec 12, 2023
Merged

image_template: enable image template version name #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dc98dc
image_template: allow to setup template version name
mmartinv Nov 27, 2023
213aa32
image_template: allow to setup template OS and description
mmartinv Nov 27, 2023
25c2471
Add changelog for #733
mmartinv Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/733-enable-image-template-version-name.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
minor_changes:
- image_template - Support `template_version_name`, `template_description` and `template_operative_system`. (https://github.com/oVirt/ovirt-ansible-collection/pull/733)
3 changes: 3 additions & 0 deletions roles/image_template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ Role Variables
| glance_image_provider | UNDEF (mandatory if qcow_url is not used) | Name of the glance image provider. |
| glance_image | UNDEF (mandatory if qcow_url is not used) | This parameter specifies the name of disk in glance provider to be imported as template. |
| template_prerequisites_tasks | UNDEF | Works only with qcow image. Specify a path to Ansible tasks file, which should be executed on virtual machine before creating a template from it. Note that qcow image must contain guest agent which reports IP address. |
| template_version_name | "base version" | Version name of the template. Allows to create different versions of a template. |
mnecas marked this conversation as resolved.
Show resolved Hide resolved
| template_description | UNDEF | Sets the template description |
| template_operating_system | UNDEF | Sets the template Operative System |

The `template_disks` List of dictionaries can contain following attributes:

Expand Down
1 change: 1 addition & 0 deletions roles/image_template/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ template_nics:
profile_name: ovirtmgmt
interface: virtio
template_seal: true
template_version_name: "base version"

disk_resize_timeout: 60
disk_storage_domain: null
7 changes: 6 additions & 1 deletion roles/image_template/tasks/qcow2_image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@
- name: Check if template already exists
ovirt_template_info:
auth: "{{ ovirt_auth }}"
pattern: "name={{ template_name }} and datacenter={{ dc_info.ovirt_datacenters[0].name }}"
pattern: "name={{ template_name }} and datacenter={{ dc_info.ovirt_datacenters[0].name }}
and version_name=\"{{ template_version_name }}\""
register: template_info
tags:
- ovirt-template-image
Expand Down Expand Up @@ -230,6 +231,10 @@
cluster: "{{ template_cluster }}"
timeout: "{{ template_timeout }}"
seal: "{{ template_seal }}"
version:
name: "{{ template_version_name }}"
description: "{{ template_description | default(omit)}}"
operating_system: "{{ template_operating_system | default(omit)}}"
when: template_info.ovirt_templates | length == 0
tags:
- ovirt-template-image
Expand Down
Loading