Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix the ansible-lint issues #713

Merged
merged 2 commits into from
Jul 20, 2023
Merged

CI: Fix the ansible-lint issues #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f178af6
CI: Fix the ansible-lint issues
mnecas Jul 19, 2023
e3ac37a
Merge branch 'master' into fix_ci
mnecas Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions roles/engine_setup/tests/test-4.2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
---
- import_playbook: containers-deploy.yml
- import_playbook: engine-deploy.yml
- name: Import containers-deploy.yml
import_playbook: containers-deploy.yml
- name: Import engine-deploy.yml
import_playbook: engine-deploy.yml
vars:
ovirt_engine_setup_version: "4.2"
ovirt_release_rpm: "http://plain.resources.ovirt.org/pub/yum-repo/ovirt-release42.rpm"
6 changes: 4 additions & 2 deletions roles/engine_setup/tests/test-master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
---
- import_playbook: containers-deploy.yml
- import_playbook: engine-deploy.yml
- name: Import containers-deploy.yml
import_playbook: containers-deploy.yml
- name: Import engine-deploy.yml
import_playbook: engine-deploy.yml
vars:
ovirt_engine_setup_version: "4.5"
ovirt_release_rpm: "http://plain.resources.ovirt.org/pub/yum-repo/ovirt-release-master.rpm"
9 changes: 6 additions & 3 deletions roles/engine_setup/tests/test-upgrade-4.2-to-master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
---
- import_playbook: containers-deploy.yml
- import_playbook: engine-deploy.yml
- name: Import containers-deploy.yml
import_playbook: containers-deploy.yml
- name: Import engine-deploy.yml 4.2
import_playbook: engine-deploy.yml
vars:
ovirt_engine_setup_version: "4.2"
ovirt_release_rpm: "http://plain.resources.ovirt.org/pub/yum-repo/ovirt-release42.rpm"
- import_playbook: engine-upgrade.yml
- name: Import engine-deploy.yml 4.3
import_playbook: engine-upgrade.yml
vars:
ovirt_engine_setup_version: "4.3"
ovirt_release_rpm: "http://plain.resources.ovirt.org/pub/yum-repo/ovirt-release-master.rpm"
10 changes: 5 additions & 5 deletions roles/hosted_engine_setup/tasks/create_target_vm/03_hosted_engine_final_tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
chdir: "{{ he_local_vm_dir }}"
become: true
become_user: vdsm
become_method: sudo
become_method: ansible.builtin.sudo
changed_when: true
tags: ['skip_ansible_lint']
- name: Create ovirt-hosted-engine-ha run directory
Expand Down Expand Up @@ -190,7 +190,7 @@
environment: "{{ he_cmd_lang }}"
become: true
become_user: vdsm
become_method: sudo
become_method: ansible.builtin.sudo
changed_when: true
- name: Initialize metadata volume
# Data is written at offset 4KiB*host_id and since ovirt supports 250 hosts per dc,
Expand All @@ -199,7 +199,7 @@
environment: "{{ he_cmd_lang }}"
become: true
become_user: vdsm
become_method: sudo
become_method: ansible.builtin.sudo
changed_when: true
- include_tasks: ../get_local_vm_disk_path.yml
- name: Generate DHCP network configuration for the engine VM
Expand Down Expand Up @@ -279,14 +279,14 @@
environment: "{{ he_cmd_lang }}"
become: true
become_user: vdsm
become_method: sudo
become_method: ansible.builtin.sudo
changed_when: true
- name: Verify copy of VM disk
ansible.builtin.command: qemu-img compare {{ local_vm_disk_path }} {{ he_virtio_disk_path }}
environment: "{{ he_cmd_lang }}"
become: true
become_user: vdsm
become_method: sudo
become_method: ansible.builtin.sudo
changed_when: true
when: he_debug_mode|bool
- name: Remove rule from fapolicy
Expand Down
Loading