Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

Add field in MemoryPolicy to control the duration of the Inflight Debouncer #374

Open
wants to merge 1 commit into
base: feature/rx2
Choose a base branch
from

Conversation

Eradash
Copy link

@Eradash Eradash commented Dec 26, 2018

I needed a shorter period of time for this variable, so I created a variable to make it custom.

… control the duration of the Inflight Debouncer
@digitalbuddha
Copy link
Contributor

Thank you for the contribution, could you kindly add tests and fix the checkstyle voliation. Thank you

this.expireAfterWrite = expireAfterWrite;
this.expireAfterAccess = expireAfterAccess;
this.expireAfterTimeUnit = expireAfterTimeUnit;
this.maxSize = maxSize;
this.maximumInFlightRequestsDurationInSeconds = maximumInFlightRequestsDurationInSeconds;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think allowing a timeunit + duration would be more consistent with rest of api

Copy link
Contributor

@digitalbuddha digitalbuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to timeunit/tests and fix build :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants