Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submit add-on]: Access8Math 3.6 #982

Merged
merged 1 commit into from
Jun 26, 2023
Merged

[Submit add-on]: Access8Math 3.6 #982

merged 1 commit into from
Jun 26, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Closes #981

@github-actions
Copy link
Contributor Author

Modifications to submitted add-ons will not be auto-approved

@seanbudd
Copy link
Member

Hi @tsengwoody - you closed #981, but #982 is still open. Have you modified the release of Access8Math 3.6? Should this still be merged?

@tsengwoody
Copy link

No, this pull request can be closed. I have already updated the version to 3.6.2, and it has been automatically merged.

@seanbudd
Copy link
Member

@tsengwoody - However, Access8Math SHA has changed, so this should still be merged. It is important that download links always return the same file, otherwise SHAs will mismatch.

@seanbudd seanbudd merged commit 4c3131a into master Jun 26, 2023
@seanbudd seanbudd deleted the tsengwoody981 branch June 26, 2023 00:48
@seanbudd
Copy link
Member

seanbudd commented Jul 2, 2023

@tsengwoody - It seems like the Access8Math SHA has changed yet again for version 3.6.0. Do you mind if I open a PR to remove this version from the add-on store? The add-on store does not support hosting add-on versions where the file downloaded by the submission link changes over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Submit add-on]: Access8Math 3.6
2 participants